QueryResultTypeWalker: fix nullability checks over unknown type #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Jun 25, 2024
janedbal
force-pushed
the
fix-nullable-mixed
branch
from
37059c3 to
fdbbb63
Compare
janedbal
force-pushed
the
fix-nullable-mixed
branch
from
fdbbb63 to
7dc5de6
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #506
Without this fix, the new testcase fails to add nullability and the inferred type does not accept the real result (invalid type was inferred). More
mixedtests with all possible AST nodes is in the origin PR.